arturobernalg opened a new pull request, #566:
URL: https://github.com/apache/jspwiki/pull/566

   Second part of 
[JSPWIKI-90](https://issues.apache.org/jira/browse/JSPWIKI-90), on top of #565: 
the first commit of this branch is that pull request, so only the second commit 
is new here.
   
   The "More..." menu of the default template gets an entry to be notified of 
the changes of the page, or to stop being notified when already subscribed. It 
posts, with the anti-CSRF token, to the new `Subscribe.jsp`, which needs a 
logged-in user with an e-mail address in the profile and the view permission on 
the page; a GET or a POST without the token is refused. The subscriptions are 
looked up by login name, as in `SubscriptionManager`. The two labels are 
translated in all the template languages.
   
   Checked on a running instance built from this branch with a test SMTP 
server: the entry shows "Notify me of changes", subscribing changes it to "Stop 
notifying me of changes", a GET and a POST without the token get Forbidden, and 
saving a change to the page sends the mail with an absolute link. The i18n and 
subscription tests pass. The "notify me" checkbox of the new page dialog that 
the issue also mentions is not part of this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to