arturobernalg opened a new pull request, #568: URL: https://github.com/apache/jspwiki/pull/568
JSPWIKI-1319: https://issues.apache.org/jira/browse/JSPWIKI-1319 PropertyReader.loadWebAppProps() collected the Java system properties with Collectors.toMap( Object::toString, Object::toString ) over the entries of System.getProperties(). That makes both key and value "key=value", so a property passed as -Djspwiki.foo=bar was stored under the key "jspwiki.foo=bar" and never found under "jspwiki.foo". The properties are now read with stringPropertyNames() and System::getProperty. Test: PropertyReaderTest.testJspwikiSystemPropertiesAreLoaded sets a jspwiki.* system property and loads the properties. It fails on master (expected fromSystem, was null) and passes with the change; the 8 tests of PropertyReaderTest pass. ChangeLog.md and the BUILD in Release.java are updated. Not run: the full test suite of the other modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
