[ 
https://issues.apache.org/jira/browse/JSPWIKI-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135748#comment-18135748
 ] 

Arturo Bernal commented on JSPWIKI-656:
---------------------------------------

I reproduced this on current master with a test of PageRenamer. TestPage is 
renamed to FooTest with "Update referrers" on; TestPage2 contains [{InsertPage 
page='TestPage'}] and TestPage3 contains [{InsertPage page=TestPage}].

Result: both pages keep the old name. In addition, 
ReferenceManager.findReferrers returns null for TestPage and for FooTest, so 
the InsertPage plugin is not recorded as a reference to the page, and the 
renamer never takes those pages into account. DefaultPageRenamer only rewrites 
links in square brackets and CamelCase names, not the parameters of plugins.

A change would need two parts: that InsertPage registers its page as a 
reference, and that the renamer rewrites the page parameter of the plugin. 
Other plugins that take a page name as a parameter would have the same problem. 
This answers the question from 2010 about PageRenamer: it does not handle 
plugin parameters today. I have not implemented anything.

> "Update referrers" doesn't update references in "InsertPage" 
> -------------------------------------------------------------
>
>                 Key: JSPWIKI-656
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-656
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 2.8
>         Environment: Windows, GlassFish
>            Reporter: Bassem R. Selim
>            Priority: Minor
>              Labels: pull-request-available
>
> When renaming a page with "Update referrers" checked, it doesn't update the 
> page name used in "InsertPage" plugin (in another page of course)



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to