arturobernalg opened a new pull request, #612: URL: https://github.com/apache/jspwiki/pull/612
The reference manager only knew the links that the parser reports, so a page inserted in another one with the InsertPage plugin had no incoming links, and ReferringPagesPlugin listed nobody for it. scanWikiLinks now also reads the parsed text of a page that contains the plugin and adds the pages named by its parameter page, so the page that inserts is a referrer of the inserted page, as if it linked to it. The parse is only done for the pages whose text contains "InsertPage". The references follow the changes of the inserting page. The alternative is a way for a parser stage plugin to report the pages it refers to, which would add to the public API; this change names one plugin in the reference manager and adds nothing to the API. I am happy to change it if you prefer the other way. Tests: InsertPageReferencesTest (the page that inserts is a referrer and the page that links still is; the reference goes away when the plugin is removed; the plugin without the parameter is ignored). It fails without the change. Checked on a running wiki: ReferringPagesPlugin for the inserted page listed only the page that links to it, and now lists also the page that inserts it. Full "mvn clean package" passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
