[
https://issues.apache.org/jira/browse/JSPWIKI-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18145157#comment-18145157
]
ASF subversion and git services commented on JSPWIKI-1353:
----------------------------------------------------------
Commit ccf1d749ff10ee1d3959898fe70b7a4795f1a9a8 in jspwiki's branch
refs/heads/master from Arturo Bernal
[ https://gitbox.apache.org/repos/asf?p=jspwiki.git;h=ccf1d749f ]
JSPWIKI-1353 Draw the relevance bars of the search results on a scale from 0 to
100 (#611)
The score of a result goes from 0 to 100, but the bars were placed between the
lowest and the
highest score of the list, so the lowest result had a bar of 40 px whatever its
score. The
bar is now the part of the full bar that the score is: the container of the
results asks the
bar behavior for the values 0 to 100 and a bar of 0 to 400 px.
> The bars of the relevance in the search results are not proportional to the
> score
> ---------------------------------------------------------------------------------
>
> Key: JSPWIKI-1353
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1353
> Project: JSPWiki
> Issue Type: Improvement
> Reporter: Arturo Bernal
> Priority: Major
> Labels: pull-request-available
>
> Follow-up of JSPWIKI-1321 (pull request 575), from the review of Ulf Dittmer.
> In the results of a search, each score is written as a span with the class
> gBar inside a div with the class graphBars
> (templates/default/AJAXSearch.jsp), and scripts/behaviors/GraphBar.js draws
> the bar. By default the smallest value of the list gets a bar of 40 px and
> the largest one 440 px (the options offset 40 and size 400), and the other
> values are placed linearly between them. So the length of a bar tells where a
> result is between the lowest and the highest score of that list, and not what
> its score is.
> In the screenshot of the review, the scores 100, 29 and 23 have bars of about
> 440, 71 and 40 CSS pixels, which is what that formula gives: 40 + (29 - 23) /
> (100 - 23) * 400 = 71. The score 23 has a bar of 40 px, not 23% of the width.
> The reviewer expects the length of the bar to be strictly proportional to the
> value, so that a minimum that is barely visible reflects its low value.
> To decide: change the search results page only, or GraphBar.js, which is also
> what draws the graphBars of the wiki markup. I have not checked what else
> depends on its default of 40 px for the smallest bar.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)