[
https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529626#comment-13529626
]
Swapnil Ghike commented on KAFKA-604:
-------------------------------------
Wow, this is going to be fun. :) Unfortunately patch v3 here has a lot of
conflicts with patch v5 at KAFKA-646 where I have done a wholesale
reorganization of metrics. The conflicts are mostly in the use of KafkaTimer.
I agree that having a KafkaTimer object might be more efficient at runtime, but
the tradeoff is that it changes the syntax of time measurement with some
instances where we will need to pass in ({a bunch of statements spread out over
multiple lines in a block}, timer).
Victor, can you take a look at patch v5 at the other jira and see which style
of time measurement you prefer?
Perhaps Joel can also comment on the syntax changes.
> Add missing metrics in 0.8
> --------------------------
>
> Key: KAFKA-604
> URL: https://issues.apache.org/jira/browse/KAFKA-604
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Attachments: kafka_604_v1.patch, kafka_604_v2.patch, kafka_604_v3.diff
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> It would be good if we add the following metrics:
> Producer: droppedMessageRate per topic
> ReplicaManager: partition count on the broker
> FileMessageSet: logFlushTimer per log (i.e., partition). Also, logFlushTime
> should probably be moved to LogSegment since the flush now includes index
> flush time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
