[
https://issues.apache.org/jira/browse/KAFKA-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559334#comment-13559334
]
Jun Rao commented on KAFKA-708:
-------------------------------
Thanks for the patch. Overall, looks good. A couple of minor comments:
1. PartitionStateMachine: The patch sets the ISR in ZK to empty every time the
partition goes offline. This means that, in the most common case when we can
elect another broker as the leader, we will need to update ISR in ZK twice when
the leader gone, the first time to set it to empty and the second time to set
it to the new leader. I am wondering if we should set the ISR in ZK to empty in
OfflinePartitionLeaderSelector.selectLeader() just before we throw a
PartitionOfflineException. This way, in the common case, we avoid an extra ZK
write.
2. UtilTest,testCsvList(): assertTrue(emptyStringList!=null) should
probably be assertTrue(emptyList!=null)
> ISR becomes empty while marking a partition offline
> ---------------------------------------------------
>
> Key: KAFKA-708
> URL: https://issues.apache.org/jira/browse/KAFKA-708
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8, 0.8.1
> Reporter: Swapnil Ghike
> Assignee: Neha Narkhede
> Priority: Blocker
> Labels: bugs, p1
> Fix For: 0.8
>
> Attachments: kafka-708-v1.patch, kafka-request.log.2013-01-16-15
>
>
> Attached state change log shows that ISR becomes empty when a partition is
> being marked as offline.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
