[
https://issues.apache.org/jira/browse/KAFKA-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561398#comment-13561398
]
Neha Narkhede commented on KAFKA-720:
-------------------------------------
Thanks for the patch. There are some compile time errors. Few comments -
1. Each log4j statement using the helper APIs in Logging.scala should be of the
form ("error message", cause). Let's fix that.
2. Inside the while loop, catching throwable will also catching all Exceptions,
so we only need to catch Throwable and exit. This is because, in the migration
tool case, only a Kafka bug will throw an exception. In other cases, we might
know the exact type of exception that is data dependent and expected, so it
makes sense to catch those separately.
> Migration tool halts
> --------------------
>
> Key: KAFKA-720
> URL: https://issues.apache.org/jira/browse/KAFKA-720
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Sriram Subramanian
> Priority: Blocker
> Labels: p1
> Attachments: migrationtoolfix.patch, migration-tool-halts
>
>
> Migration tool halts, attaching a thread dump for further investigation
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
