[
https://issues.apache.org/jira/browse/KAFKA-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615355#comment-13615355
]
Jun Rao commented on KAFKA-828:
-------------------------------
Thanks for patch v3. A couple of comments:
1. There is a compilation error
[error]
/Users/jrao/intellij_workspace/kafka_git/core/src/main/scala/kafka/controller/PartitionLeaderSelector.scala:129:
type mismatch;
[error] found : Unit
[error] required: (kafka.api.LeaderAndIsr, Seq[Int])
[error] info("Preferred replica %d is already the current leader for
partition %s".format(preferredReplica, topicAndPartition))
[error] ^
[error] one error found
2. PreferredReplicaPartitionLeaderSelector: Is there any value in logging the
following?
info("Preferred replica %d is already the current leader for partition
%s".format(preferredReplica, topicAndPartition))
The same info will be logged in
KafkaController.removePartitionsFromPreferredReplicaElection().
3. ZkUtils.parsePreferredReplicaElectionData: This is very specific to
preferred replica election. So, it's better to move it to
PreferredReplicaLeaderElectionCommand.
> Preferred Replica Election does not delete the admin path on controller
> failover
> --------------------------------------------------------------------------------
>
> Key: KAFKA-828
> URL: https://issues.apache.org/jira/browse/KAFKA-828
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Priority: Blocker
> Labels: bugs, kafka-0.8, p1
> Fix For: 0.8
>
> Attachments: kafka-828-v1.patch, kafka-828-v2.patch,
> kafka-828-v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
