[ 
https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jun Rao updated KAFKA-649:
--------------------------

    Attachment: kafka-649.patch

A lot of the logging has already been fixed in other patches. Made another pass 
and attach a patch. It fixes the following:

1. On startup, we currently log the loading of every data and index segment. 
That's probably too much. Instead, only log the logEndOffset after loading the 
log.

2. Added topic/partition info in a few places where this is useful.

3. Added the type of request in a few places in KafkaApis to make it clear what 
request is the error for.

4. Moved a few less important logging from info to debug.
                
> Cleanup log4j logging
> ---------------------
>
>                 Key: KAFKA-649
>                 URL: https://issues.apache.org/jira/browse/KAFKA-649
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Jay Kreps
>            Assignee: Jun Rao
>            Priority: Blocker
>         Attachments: kafka-649.patch
>
>
> Review the logs and do the following:
> 1. Fix confusing or duplicative messages
> 2. Assess that messages are at the right level (TRACE/DEBUG/INFO/WARN/ERROR)
> It would also be nice to add a log4j logger for the request logging (i.e. the 
> access log) and another for the controller state change log, since these 
> really have their own use cases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to