[
https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627279#comment-13627279
]
Neha Narkhede commented on KAFKA-649:
-------------------------------------
These are good changes. Few more suggestions -
1. A pattern that needs change is "topic %s partition %d". We need to
standardize on "[%s,%d]" so that grepping through the logs for a particular
topic/partition is easy.
2. In OfflinePartitionLeaderSelector.selectLeader(),
warn("No broker in ISR is alive for %s. Elect leader from
broker %s. There's potential data loss."
.format(topicAndPartition, newLeader))
needs to change to
warn("No broker in ISR is alive for %s. Elect leader %d from
brokers %s. There's potential data loss."
.format(topicAndPartition, newLeader,
liveAssignedReplicasToThisPartition.mkString(",")))
3. Similarly, change
debug("Some broker in ISR is alive for %s. Select %d from ISR to be
the leader.".format(topicAndPartition, newLeader))
to
debug("Some broker in ISR is alive for %s. Select %d from ISR %s to
be the leader.".format(topicAndPartition, newLeader,
liveBrokersInIsr.mkString(",")))
4. KafkaApis
As mentioned in #1, we want to move away from "topic %s partition %d" -
error("Error when processing fetch request for topic %s partition
%d offset %d from %s with correlation id %d"
.format(topic, partition, offset, if (isFetchFromFollower)
"follower" else "consumer", fetchRequest.correlationId),
t)
> Cleanup log4j logging
> ---------------------
>
> Key: KAFKA-649
> URL: https://issues.apache.org/jira/browse/KAFKA-649
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8
> Reporter: Jay Kreps
> Assignee: Jun Rao
> Priority: Blocker
> Attachments: kafka-649.patch
>
>
> Review the logs and do the following:
> 1. Fix confusing or duplicative messages
> 2. Assess that messages are at the right level (TRACE/DEBUG/INFO/WARN/ERROR)
> It would also be nice to add a log4j logger for the request logging (i.e. the
> access log) and another for the controller state change log, since these
> really have their own use cases.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
