[ 
https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630562#comment-13630562
 ] 

Scott Carey commented on KAFKA-843:
-----------------------------------

Another suggestion:

What if buildNumber was only appended to the version?

So the current version on the branch is 0.8-SNAPSHOT, and adding a build number 
"12345" gives:

"0.8-SNAPSHOT-12345"

And if the version was "0.8.beta1" adding a build number would be:

"0.8.beta1-12345"

My reasoning is that it is nice to consolidate the "true current version" into 
one value and have that be set in one place and not constructed.  This includes 
when there is a SNAPSHOT and when there is not.  This is so that a release 
process would involve changing that one value, committing, and tagging -- what 
is committed and tagged as a release will have the version set in source, not 
ephemeral in the environment that built it.
                
> Re-add the release-zip sbt target
> ---------------------------------
>
>                 Key: KAFKA-843
>                 URL: https://issues.apache.org/jira/browse/KAFKA-843
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: packaging
>    Affects Versions: 0.8
>            Reporter: Cosmin Lehene
>            Assignee: Cosmin Lehene
>             Fix For: 0.8
>
>         Attachments: KAFKA-843.patch, KAFKA-843.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> This target has been removed a while ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to