[ 
https://issues.apache.org/jira/browse/KAFKA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674598#comment-13674598
 ] 

Joel Koshy commented on KAFKA-927:
----------------------------------

+1 - sorry I got to this late.

Small nit: the scaladoc for shutdown broker needs an edit which we will clean 
up later.
We probably don't need the adminTest's testShutdownBroker given that the 
rolling bounce test exercises the same logic.

Also, I think we can close KAFKA-817 - another approach with similar goals.


                
> Integrate controlled shutdown into kafka shutdown hook
> ------------------------------------------------------
>
>                 Key: KAFKA-927
>                 URL: https://issues.apache.org/jira/browse/KAFKA-927
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Sriram Subramanian
>            Assignee: Sriram Subramanian
>             Fix For: 0.8
>
>         Attachments: KAFKA-927.patch, KAFKA-927-v2.patch, 
> KAFKA-927-v2-revised.patch, KAFKA-927-v3.patch, 
> KAFKA-927-v3-removeimports.patch, KAFKA-927-v4.patch
>
>
> The controlled shutdown mechanism should be integrated into the software for 
> better operational benefits. Also few optimizations can be done to reduce 
> unnecessary rpc and zk calls. This patch has been tested on a prod like 
> environment by doing rolling bounces continuously for a day. The average time 
> of doing a rolling bounce with controlled shutdown for a cluster with 7 nodes 
> without this patch is 340 seconds. With this patch it reduces to 220 seconds. 
> Also it ensures correctness in scenarios where the controller shrinks the isr 
> and the new leader could place the broker to be shutdown back into the isr.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to