[ 
https://issues.apache.org/jira/browse/KAFKA-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705340#comment-13705340
 ] 

Joel Koshy commented on KAFKA-969:
----------------------------------

This seems reasonable, but I'm not fully convinced about it. E.g., a test
framework should ensure external dependencies are up before attempting to
make service calls to those dependencies. That said, it is perhaps also
reasonable from a consumer's perspective to expect that returned streams be
empty at first, and whenever brokers and topics show up, then events should
just show up.

I'm +1 on this patch except for the if-else formatting issue.  Also, I think
this patch alone would be insufficient to meet the above.  There are two
other issues:

- We should register a watcher under the topics path (currently done only if
  a wildcard is specified)
- KAFKA-956 is also related. I need to give that one some thought.



                
> Need to prevent failure of rebalance when there are no brokers available when 
> consumer comes up
> -----------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-969
>                 URL: https://issues.apache.org/jira/browse/KAFKA-969
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Sriram Subramanian
>            Assignee: Sriram Subramanian
>         Attachments: emptybrokeronrebalance-1.patch
>
>
> There are some rare instances when a consumer would be up before bringing up 
> the Kafka brokers. This would usually happen in a test scenario. In such 
> conditions, during rebalance instead of failing the rebalance we just log the 
> error and subscribe to broker changes. When the broker comes back up, we 
> trigger the rebalance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to