[
https://issues.apache.org/jira/browse/KAFKA-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725425#comment-13725425
]
Jun Rao commented on KAFKA-984:
-------------------------------
Thanks for patch v2. Some comments:
20. It seems that we should be able to deal with the addition of multiple
topics, not just a single one.
21. There is code in handleAddNewTopicForFilteredStreams very similar to what's
in reinitializeConsumer (the part that generates the (topic,threadId)->queue
mapping). It would be good if we can avoid the duplication.
22. rebalance() currently closes all fetchers at the beginning. For
syncdPartialRelance() to work, we have to prevent closing the fetchers for
existing partitions.
The fix seems bigger than I expected. So, I am not sure if we should fix it in
0.8 or trunk. Could you make another pass? We can make the call then. Finally,
in the future, it would be clearer to upload new patches with a different
version. If a version needs to be replaced, you can delete the old one.
> Avoid a full rebalance in cases when a new topic is discovered but
> container/broker set stay the same
> -----------------------------------------------------------------------------------------------------
>
> Key: KAFKA-984
> URL: https://issues.apache.org/jira/browse/KAFKA-984
> Project: Kafka
> Issue Type: Bug
> Reporter: Guozhang Wang
> Assignee: Guozhang Wang
> Fix For: 0.8
>
> Attachments: KAFKA-984.v1.patch, KAFKA-984.v2.patch,
> KAFKA-984.v2.patch
>
>
> Currently a full rebalance will be triggered on high level consumers even
> when just a new topic is added to ZK. Better avoid this behavior but only
> rebalance on this newly added topic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
