[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737045#comment-13737045
]
Jun Rao commented on KAFKA-990:
-------------------------------
Thanks for the patch. Looks good overall. Some comments.
1. KafkaController:
1.1 onPartitionReassignment(): The comment above the function needs to be
updated. For example, we no longer register the ISR listener here.
1.2 initiateReassignPartitionForTopic(): We fail the reassignment if not all
brokers in RAR are alive. I am wondering if this is necessary. A broker can go
down when the reassignment process is in progress and we still need to handle
this case.
1.3 Should watchIsrChangesForReassignedPartition() be private?
2. ReassignPartitionsCommand
2.1 It seems that we don't allow the options "topics-to-move-json-file" and
"manual-assignment-json-file" to co-exist. Could we add an explicit check and
output an appropriate message?
2.2 If "broker-list" is not specified, it seems that we should default to the
current list of live brokers.
2.3 Could we somehow make dryRun the default behavior? In other words, the user
has to add another option to disable dry run.
3. Since the reassignment process requires fetching old data and may pollute
the pagecache, do you see any performance impact to produce/fetch request
latency when the reassignment is in progress?
> Fix ReassignPartitionCommand and improve usability
> --------------------------------------------------
>
> Key: KAFKA-990
> URL: https://issues.apache.org/jira/browse/KAFKA-990
> Project: Kafka
> Issue Type: Bug
> Reporter: Sriram Subramanian
> Assignee: Sriram Subramanian
> Attachments: KAFKA-990-v1.patch, KAFKA-990-v1-rebased.patch
>
>
> 1. The tool does not register for IsrChangeListener on controller failover.
> 2. There is a race condition where the previous listener can fire on
> controller failover and the replicas can be in ISR. Even after re-registering
> the ISR listener after failover, it will never be triggered.
> 3. The input the tool is a static list which is very hard to use. To improve
> this, as a first step the tool needs to take a list of topics and list of
> brokers to do the assignment to and then generate the reassignment plan.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
