Thanks for the review. I created a JIRA to track this -
https://issues.apache.org/jira/browse/KAFKA-1053. Will be great if you can
add your comments there.
Thanks,
Neha
On Wed, Sep 11, 2013 at 11:28 AM, Tejas Patil <tejas.patil...@gmail.com>wrote:
> This is cool !!! I can't wait to use it.
>
> Some comments:
>
> (1) In [0], "Setup" -> hyperlinks on steps 1 and 2 loop to the same
> webpage.
>
> (2) I don't have much idea about the right place where the ".reviewboardrc"
> file should be, but it would be a good idea to commit it in the codebase
> like [1]. Also, add it to .gitignore (like [2]).
>
> (3) How about adding "kafka-rb.py" to kafka codebase ? With that *maybe*
> there won't be any need for JIRA_CMDLINE_HOME.
>
> (4) In kafka-rb.py:
>
> > popt.add_argument('-s', '--summary', action='store', dest='summary',
> required=False, help='Summary for the reviewboard')
> > popt.add_argument('-d', '--description', action='store',
> dest='description', required=False
>
> I am wondering if someone doesn't provide a summary and as its an optional
> param the script won;t complain. RB dashboard would end up having a bunch
> of tickets with no summary or title.
>
> (6) > print 'Creating reviewboard'
> Could this message sound good: "Generating a new review board ticket" ?
>
> (7) Is there a way to specify the "Testing Done" text of RB through this
> script ?
>
> [0] :
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool
> [1] : https://issues.apache.org/jira/browse/GIRAPH-331
> [2] : https://issues.apache.org/jira/browse/TAJO-69
>
> Thanks,
> Tejas
>
>
> On Wed, Sep 11, 2013 at 11:00 AM, Guozhang Wang <wangg...@gmail.com>
> wrote:
>
> > Hooray! Thanks Neha.
> >
> > Guozhang
> >
> >
> > On Wed, Sep 11, 2013 at 10:50 AM, Neha Narkhede <neha.narkh...@gmail.com
> > >wrote:
> >
> > > I wrote a wrapper script that will update the jira as well as the
> > > reviewboard. So the proposed new patch review process will be -
> > >
> > > 1. Create JIRA
> > > 2. Make code changes and commit to local branch
> > > 3. Use patch review
> > > tool<
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool#Kafkapatchreviewtool-KafkaJIRAandReviewboardscript
> > > >that
> > > will create/update a reviewboard as well as upload the patch to JIRA
> > > 4. Reviewers will "ship it" on the reviewboard
> > > 5. Committer will take the patch and manually mark the JIRA resolved.
> We
> > > can potentially have a committer tool that will automatically resolve
> the
> > > JIRA as well.
> > >
> > > Wiki is here -
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool#Kafkapatchreviewtool-KafkaJIRAandReviewboardscript
> > >
> > > Thanks,
> > > Neha
> > >
> > >
> > > On Mon, Sep 9, 2013 at 9:18 PM, Jay Kreps <jay.kr...@gmail.com> wrote:
> > >
> > > > Yeah the lack of integration is kind of maddening if you have ever
> used
> > > > github.
> > > >
> > > > My recommendation is that we treat Review Board as just a patch
> viewer
> > > and
> > > > discussion tool. In other words you must have a JIRA and a link to
> the
> > > > appropriate review board there. We should make no effort to use
> review
> > > > board's dashboard or close the rbs or anything like that. I think it
> is
> > > > reasonable to give the +1 in RB, though.
> > > >
> > > > Not sure how other projects do it.
> > > >
> > > > One simple thing that would help would be to get a wrapper script for
> > > > post-review and the jira command-line tool (
> > > >
> > > >
> > >
> >
> https://bobswift.atlassian.net/wiki/display/JCLI/JIRA+Command+Line+Interface
> > > > ).
> > > > I want something that takes a JIRA such as KAFKA-123 and generates a
> > > patch
> > > > and uploads it to both JIRA and rb, updating an existing rb if one is
> > > > specified.
> > > >
> > > > -Jay
> > > >
> > > >
> > > > On Mon, Sep 9, 2013 at 2:32 PM, Guozhang Wang <wangg...@gmail.com>
> > > wrote:
> > > >
> > > > > Same concern. It seems that ReviewBoard would not, say, mark the
> JIRA
> > > as
> > > > > patch available when request is published. Does that mean we have
> to
> > > keep
> > > > > doing this manually still?
> > > > >
> > > > > Guozhang
> > > > >
> > > > >
> > > > > On Sun, Sep 8, 2013 at 10:04 AM, Neha Narkhede <
> > > neha.narkh...@gmail.com
> > > > > >wrote:
> > > > >
> > > > > > This is great. So far I reviewed 2 patches using reviewboard and
> it
> > > is
> > > > a
> > > > > > huge time saver. I have one question about the setup though - the
> > > > > > reviewboard has a Bugs field that takes in the JIRA, can it
> update
> > > the
> > > > > > respective JIRA with the reviewboard link ? The concern is that
> > with
> > > > > more
> > > > > > reviews coming in through review board, it will soon become
> > > intractable
> > > > > > since there is also no easy way to search by Bug in reviewboard.
> > > > > >
> > > > > > Thanks,
> > > > > > Neha
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Mon, Aug 26, 2013 at 1:00 PM, Jay Kreps <jay.kr...@gmail.com>
> > > > wrote:
> > > > > >
> > > > > > > Okay I got review board set up. I'm not wedded to this tool,
> but
> > > it's
> > > > > > > pretty simple so let's give it a try and if it sucks we can
> > switch
> > > to
> > > > > > > phabricator or something else.
> > > > > > >
> > > > > > > I wrote up instructions on how to use it here:
> > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/Review+Board
> > > > > > >
> > > > > > > If anyone has better info on workflow it would be great to help
> > > > people
> > > > > > > figure it out. Ideally if we end up liking this tool it would
> be
> > > good
> > > > > to
> > > > > > > integrate it into the git workflow tool and ideally have some
> > > script
> > > > to
> > > > > > > handle both the JIRA attachment and the review board.
> > > > > > >
> > > > > > > -Jay
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > -- Guozhang
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > -- Guozhang
> >
>
