-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 16, 2013, 9:40 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Addressing issues that Swapnil ran into 1) Passing the --debug option to
post-review to get meaningful debug messages from post-review in case it fails
2) Adding git remote update in the script since that is a common reason for the
post-review failing 3) Improved error message reporting
Addressing issues that Swapnil ran into 1) Passing the --debug option to
post-review to get meaningful debug messages from post-review in case it fails
2) Adding git remote update in the script since that is a common reason for the
post-review failing 3) Improved error message reporting
1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2)
Improved error handling to handle the case if the patch is empty 3) Prevent
uploading patch and updating/creating reviewboard if patch is empty or diff is
not checked into local branch
Use underscore to separate jira, date and time in patch name
Addressed Swapnil's review comments - 1) Closed the file handle for the git
command 2) Removed the --version command line option and automated version to
be the timestamp
Included Guozhang's suggestion about making --version mandatory if --rb is
specified
Included Guozhang's suggestion about making --version mandatory if --rb is
specified
Attaching file using jira-python package
Changed the script to use the jira-python package, part 2
Changed the script to use the jira-python package
Changed the creating a reviewboard comment as suggested by Tejas
Included Tejas's comments
Changed the post-review tool to publish the rb automatically. Updated the tool
to add a link to the rb in the JIRA
publish automatically
Patch review tool
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
