[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770270#comment-13770270
]
Joel Koshy commented on KAFKA-1053:
-----------------------------------
Nice - I tried this on KAFKA-1049 (as a test - that patch does not work) and it
worked great!
+1
I did not get time to dig into the issue I ran into on Linux but the steps
worked on my laptop. I can look into that and update the wiki with a
work-around if I find one.
Minor comment: the direct Python API is interesting
http://www.reviewboard.org/docs/rbtools/dev/api/overview (I'm in general wary
of popen/subprocess); but it is probably more work than its worth to interface
with that and post-review likely wraps that anyway and is a well-maintained
tool. Also, would prefer to have the tool create a os.tmpfile as opposed to
leaving around a patch file but not a big deal.
> Kafka patch review tool
> -----------------------
>
> Key: KAFKA-1053
> URL: https://issues.apache.org/jira/browse/KAFKA-1053
> Project: Kafka
> Issue Type: New Feature
> Components: tools
> Reporter: Neha Narkhede
> Assignee: Neha Narkhede
> Attachments: KAFKA-1053-2013-09-15_09:40:04.patch,
> KAFKA-1053_2013-09-15_20:28:01.patch, KAFKA-1053_2013-09-16_14:40:15.patch,
> KAFKA-1053-followup2.patch, KAFKA-1053-followup.patch, KAFKA-1053-v1.patch,
> KAFKA-1053-v1.patch, KAFKA-1053-v1.patch, KAFKA-1053-v2.patch,
> KAFKA-1053-v3.patch
>
>
> Created a new patch review tool that will integrate JIRA and reviewboard -
> https://cwiki.apache.org/confluence/display/KAFKA/Kafka+patch+review+tool
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
