----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14497/#review26712 -----------------------------------------------------------
With the new change, will a rebalance be triggered on a consumer when #partitions is changed on a consumed topic? config/tools-log4j.properties <https://reviews.apache.org/r/14497/#comment52026> This change is probably not intended. core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala <https://reviews.apache.org/r/14497/#comment52027> This is a bit misleading. We are not registering the listener here. We only instantiated the listener. Ditto for the comment above sessionExpirationListener. - Jun Rao On Oct. 4, 2013, 10:23 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14497/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 10:23 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1075 > https://issues.apache.org/jira/browse/KAFKA-1075 > > > Repository: kafka > > > Description > ------- > > KAFKA-1075.v1 > > > Diffs > ----- > > config/tools-log4j.properties 79240490149835656e2a013a9702c5aa41c104f1 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > 08b4b7218f62f876eb95628bd6db78c0956c7f04 > > Diff: https://reviews.apache.org/r/14497/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
