[
https://issues.apache.org/jira/browse/KAFKA-1081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792936#comment-13792936
]
Jay Kreps commented on KAFKA-1081:
----------------------------------
Yeah I agree, rerunning the command to get the error is really weird. Given
that we have a binary release do we need to retain this behavior? I.e. if you
download the source release and try to run without building then it won't work
but this shouldn't be as confusing as it was when we only had a source release
and didn't really label the download as such.
> kafka-run-class.sh is broken
> ----------------------------
>
> Key: KAFKA-1081
> URL: https://issues.apache.org/jira/browse/KAFKA-1081
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Francois Saint-Jacques
>
> Please apply this patch, this is why log4j exists. Rerunning at
> non-deterministic command twice to catch error message is extremely dangerous.
> diff --git a/bin/kafka-run-class.sh b/bin/kafka-run-class.sh
> index eb6ff1b..2f2d8b5 100755
> --- a/bin/kafka-run-class.sh
> +++ b/bin/kafka-run-class.sh
> @@ -102,19 +102,3 @@ if [ "$1" = "daemon" ] && [ -z "$KAFKA_GC_LOG_OPTS"] ;
> then
> fi
> $JAVA $KAFKA_HEAP_OPTS $KAFKA_JVM_PERFORMANCE_OPTS $KAFKA_GC_LOG_OPTS
> $KAFKA_JMX_OPTS $KAFKA_LOG4J_OPTS -cp $CLASSPATH $KAFKA_OPTS "$@"
> -
> -exitval=$?
> -
> -if [ $exitval -eq "1" ] ; then
> - $JAVA $KAFKA_HEAP_OPTS $KAFKA_JVM_PERFORMANCE_OPTS $KAFKA_GC_LOG_OPTS
> $KAFKA_JMX_OPTS $KAFKA_LOG4J_OPTS -cp $CLASSPATH $KAFKA_OPTS "$@" >&
> exception.txt
> - exception=`cat exception.txt`
> - noBuildMessage='Please build the project using sbt. Documentation is
> available at http://kafka.apache.org/'
> - pattern="(Could not find or load main
> class)|(java\.lang\.NoClassDefFoundError)"
> - match=`echo $exception | grep -E "$pattern"`
> - if [[ -n "$match" ]]; then
> - echo $noBuildMessage
> - fi
> - rm exception.txt
> -fi
> -
> -
--
This message was sent by Atlassian JIRA
(v6.1#6144)
