> On Oct. 15, 2013, 8:03 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/GetOffsetShell.scala, line 63 > > <https://reviews.apache.org/r/14638/diff/1/?file=364653#file364653line63> > > > > Can use CommandLineUtils.checkRequiredArgs
Fixed this. Thanks for pointing this out! > On Oct. 15, 2013, 8:03 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/tools/GetOffsetShell.scala, line 89 > > <https://reviews.apache.org/r/14638/diff/1/?file=364653#file364653line89> > > > > Should this be partitionList.split(",")... Fixed this. Good catch! - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14638/#review27039 ----------------------------------------------------------- On Oct. 16, 2013, 11:29 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14638/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2013, 11:29 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1086 > https://issues.apache.org/jira/browse/KAFKA-1086 > > > Repository: kafka > > > Description > ------- > > Incorporated Joel's review comments > > > Minor change to patch review tool > > > Changed command line parameter partition->partitions > > > Improved GetOffsetShell to query metadata automatically, add batch offset > request for all partitions of a topic and improve usability > > > Diffs > ----- > > core/src/main/scala/kafka/tools/GetOffsetShell.scala > 2b9438ae3a4da2c7f97e05fb26bc179fe48f137d > kafka-patch-review.py f1d5192057755e9cd24861c1f995638e2eada1d1 > > Diff: https://reviews.apache.org/r/14638/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
