----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14771/#review27228 -----------------------------------------------------------
Thanks for the patch. The issue is that firstAppendTime is no longer accurate after a broker restart. Also, this patch should probably be done in trunk, instead of 0.8 since it doesn't seem to be a blocker. - Jun Rao On Oct. 19, 2013, 10:34 p.m., Swapnil Ghike wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14771/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2013, 10:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1093 > https://issues.apache.org/jira/browse/KAFKA-1093 > > > Repository: kafka > > > Description > ------- > > Log.getOffsetsBefore(t, …) does not return the last confirmed offset before t > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > f6348969ea38258065f4de358bfbf3f20b4eb74a > > Diff: https://reviews.apache.org/r/14771/diff/ > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Swapnil Ghike > >
