[jira] [Commented] (KAFKA-1098) Unit test failure in 0.8.1 related to LogCleaner

[Jun Rao (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KAFKA-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802950#comment-13802950
 ] 

Jun Rao commented on KAFKA-1098:
--------------------------------

Thanks for the patch. It doesn't compile with scala 2.10.1 though since 
asIterable no longer exists there. I guess we have to import all 
JavaConversions._ to get around the cross compilation issue.
[error] 
/Users/jrao/Intellij/kafka_git/core/src/main/scala/kafka/log/Log.scala:589: 
value asIterable is not a member of object scala.collection.JavaConversions
[error]     import JavaConversions.asIterable
[error]            ^

Also, in the following places, should we use eq to test null for the returned 
entry from the skipListMap?

In read(),
    if(startOffset > next || entry == null)

In roll(),
      segments.lastEntry() match {
        case null => 
        case entry => entry.getValue.index.trimToValidSize()
      }


> Unit test failure in 0.8.1 related to LogCleaner
> ------------------------------------------------
>
>                 Key: KAFKA-1098
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1098
>             Project: Kafka
>          Issue Type: Bug
>          Components: log
>    Affects Versions: 0.8.1
>            Reporter: Neha Narkhede
>            Assignee: Jay Kreps
>         Attachments: kafka_1098-v1.patch, KAFKA-1098-v2.patch
>
>
> Floor = 0, To = -1
> [2013-10-22 09:39:25,001] ERROR Error in cleaner thread 0: 
> (kafka.log.LogCleaner:103)
> java.lang.IllegalArgumentException: inconsistent range
>       at 
> java.util.concurrent.ConcurrentSkipListMap$SubMap.<init>(ConcurrentSkipListMap.java:2506)
>       at 
> java.util.concurrent.ConcurrentSkipListMap.subMap(ConcurrentSkipListMap.java:1984)
>       at kafka.log.Log.logSegments(Log.scala:605)
>       at kafka.log.LogToClean.<init>(LogCleaner.scala:596)
>       at kafka.log.LogCleaner$$anonfun$5.apply(LogCleaner.scala:137)
>       at kafka.log.LogCleaner$$anonfun$5.apply(LogCleaner.scala:137)
>       at 
> scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:206)
>       at 
> scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:206)
>       at 
> scala.collection.LinearSeqOptimized$class.foreach(LinearSeqOptimized.scala:61)
>       at scala.collection.immutable.List.foreach(List.scala:45)
>       at scala.collection.TraversableLike$class.map(TraversableLike.scala:206)
>       at scala.collection.immutable.List.map(List.scala:45)
>       at 
> kafka.log.LogCleaner.kafka$log$LogCleaner$$grabFilthiestLog(LogCleaner.scala:137)
>       at kafka.log.LogCleaner$CleanerThread.cleanOrSleep(LogCleaner.scala:203)
>       at kafka.log.LogCleaner$CleanerThread.run(LogCleaner.scala:189)



--
This message was sent by Atlassian JIRA
(v6.1#6144)