----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15274/#review28385 -----------------------------------------------------------
core/src/main/scala/kafka/admin/AdminUtils.scala <https://reviews.apache.org/r/15274/#comment55214> Would it be better to do validation of all configs (to be removed and altered) earlier - i.e., in parseTopicConfigs? core/src/main/scala/kafka/admin/TopicCommand.scala <https://reviews.apache.org/r/15274/#comment55206> As part of this patch, can you change the regex to use the """ format: i.e., """\s*=\s*""" I think that's clearer in that it avoids double escapes. Also, we should probably trim the split strings. core/src/main/scala/kafka/admin/TopicCommand.scala <https://reviews.apache.org/r/15274/#comment55207> This convention should be fine, but personally would prefer an unconfig or del-config since people can easily make mistakes and miss the actual config value they intend to alter. - joel koshy On Nov. 7, 2013, 5:50 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15274/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 5:50 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1119 > https://issues.apache.org/jira/browse/KAFKA-1119 > > > Repository: kafka > > > Description > ------- > > Add an explicit --deleteConfig option > > > more cleanup > > > Code cleanup > > > Fixed bug that now allows removing all the topic overrides correctly and > falling back to the defaults > > > 1. Change the --config to diff the previous configs 2. Add the ability to > remove per topic overrides if config is specified without a value > > > Diffs > ----- > > core/src/main/scala/kafka/admin/AdminUtils.scala > 8107a64cf1ef1cac763e152bae9f835411c9d3f3 > core/src/main/scala/kafka/admin/TopicCommand.scala > 56f3177e28a34df0ace1d192aef0060cb5e235df > core/src/main/scala/kafka/log/LogConfig.scala > 51ec796e9e6a10b76daefbd9aea02121fc1d573a > core/src/main/scala/kafka/server/TopicConfigManager.scala > 56cae58f2a216dcba88b2656fd4a490f11461270 > > Diff: https://reviews.apache.org/r/15274/diff/ > > > Testing > ------- > > Locally tested - 1. Adding new config 2. Adding new invalid config 3. > Deleting config 4. Deleting all config overrides > > > Thanks, > > Neha Narkhede > >
