[
https://issues.apache.org/jira/browse/KAFKA-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816331#comment-13816331
]
Timothy Chen commented on KAFKA-1036:
-------------------------------------
Hi Jay,
The code isn't doing any locking, but looks like in Windows if you don't close
the writer there is still a pending file lock on the file itself in Windows
looking via the file monitor.
That's why I needed to add a extra writer.close after the rename fails.
Tim
> Unable to rename replication offset checkpoint in windows
> ---------------------------------------------------------
>
> Key: KAFKA-1036
> URL: https://issues.apache.org/jira/browse/KAFKA-1036
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.1
> Environment: windows
> Reporter: Timothy Chen
> Priority: Critical
> Labels: windows
> Fix For: 0.8.1
>
>
> Although there was a fix for checkpoint file renaming in windows that tries
> to delete the existing checkpoint file if renamed failed, I'm still seeing
> renaming errors on windows even though the destination file doesn't exist.
> A bit investigation shows that it wasn't able to rename the file since the
> kafka jvm still holds a fie lock on the tmp file and wasn't able to rename
> it.
> Attaching a patch that calls a explict writer.close so it can release the
> lock and can able to rename it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
