----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15201/#review28744 -----------------------------------------------------------
Looks good overall - this is definitely a useful tool to have. I'm posting comments so far but I will come back to it tomorrow to finish up. So what would be the recommended procedure when the tool reports an inconsistency? Would operations have to go in, stop the brokers and truncate the log segments to the last segments that are verified to be consistent? If so, it would be convenient if the tool could issue another OffsetRequest to report the offset boundaries of the last consistent segments so you don't have to work too hard to determine the segment file. Also, unless I'm reading it incorrect additional caveats are that the tool can only keep working so long as: partitions are not being added (or reassigned); logs are not being compacted. config/tools-log4j.properties <https://reviews.apache.org/r/15201/#comment55727> Is this needed? core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala <https://reviews.apache.org/r/15201/#comment55733> This is becoming my most frequent review comment :) Can you use CommandLineUtils.checkRequiredArgs? core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala <https://reviews.apache.org/r/15201/#comment55734> Any reason to not use kafka.consumer.Whitelist and the isTopicAllowed API that it provides? - Joel Koshy On Nov. 12, 2013, 4:34 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15201/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2013, 4:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1117 > https://issues.apache.org/jira/browse/KAFKA-1117 > > > Repository: kafka > > > Description > ------- > > kafka-1117; fix 3 > > > kafka-1117; fix 2 > > > kafka-1117; fix 1 > > > kafka-1117 > > > Diffs > ----- > > config/tools-log4j.properties 79240490149835656e2a013a9702c5aa41c104f1 > core/src/main/scala/kafka/api/OffsetResponse.scala > 08dc3cd3d166efba6b2b43f6e148f636b175affe > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/15201/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
