[ 
https://issues.apache.org/jira/browse/KAFKA-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822072#comment-13822072
 ] 

David Arthur commented on KAFKA-1131:
-------------------------------------

[~charmalloc], patch looks good, verified that it adds NOTICE and LICENSE in 
the release directory.

Two quick questions:

* Do we need to include these in the jar for the binary dist, or just for Maven?
* If I'm reading http://apache.org/legal/src-headers.html#notice right, we need 
to include 3rd party licenses in the NOTICE file of the binary dist (since we 
are distributing those 3rd party libs). I know Ivy can generate a list of all 
the licenses, so SBT probably can as well.

> copy some more files into the release tar and zip that are needed/desired
> -------------------------------------------------------------------------
>
>                 Key: KAFKA-1131
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1131
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Joe Stein
>             Fix For: 0.8, 0.8.1
>
>         Attachments: KAFKA-1131.patch
>
>
> e.g.  LICENSE, NOTICE, README (or maybe a new quick start file .txt) 



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to