----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15901/#review29535 -----------------------------------------------------------
core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/15901/#comment56886> We probably should guard the more general case, i.e, if can't find the leader broker, we will just skip this partition (rather than just handling the leader = -1 case). It's probably also useful to log the partitions that are skipped. - Jun Rao On Nov. 28, 2013, 6:36 a.m., Swapnil Ghike wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15901/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 6:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1152 > https://issues.apache.org/jira/browse/KAFKA-1152 > > > Repository: kafka > > > Description > ------- > > ReplicaManager's handling of the leaderAndIsrRequest should gracefully handle > leader == -1 > > > Diffs > ----- > > core/src/main/scala/kafka/server/ReplicaManager.scala > 161f58134f20f9335dbd2bee6ac3f71897cbef7c > > Diff: https://reviews.apache.org/r/15901/diff/ > > > Testing > ------- > > Builds with all scala versions; unit tests pass > > > Thanks, > > Swapnil Ghike > >
