[ 
https://issues.apache.org/jira/browse/KAFKA-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836141#comment-13836141
 ] 

Jun Rao commented on KAFKA-1154:
--------------------------------

The fix is to switch the ordering in ReplicaManager.makeFollowers(). We should 
first mark the replica as the follower before truncating the log. This will 
ensure that after the log is truncated, no new messages from the produce 
requests will be added to the log.

> replicas may not have consistent data after becoming follower
> -------------------------------------------------------------
>
>                 Key: KAFKA-1154
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1154
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.1
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>             Fix For: 0.8.1
>
>
> This is an issued introduced in KAFKA-1001. The issue is that in 
> ReplicaManager.makeFollowers(), we truncate the log before marking the 
> replica as the follower. New messages from the producer can still be added to 
> the log after the log is truncated, but before the replica is marked as the 
> follower. Those newly produced messages can actually be committed, which 
> implies those truncated messages are also committed. However, the new leader 
> is not guaranteed to have those truncated messages.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to