----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15938/#review29576 -----------------------------------------------------------
Ship it! core/src/main/scala/kafka/api/RequestOrResponse.scala <https://reviews.apache.org/r/15938/#comment56964> Could we add a comment why replicaId >= 0 means it is from a follower? - Guozhang Wang On Dec. 1, 2013, 11:33 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15938/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2013, 11:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1154 > https://issues.apache.org/jira/browse/KAFKA-1154 > > > Repository: kafka > > > Description > ------- > > kafka-1154; fix 1 > > > Diffs > ----- > > core/src/main/scala/kafka/api/FetchRequest.scala > fb2a2306003ac64a8a3b2fc5fc999e0be273f48d > core/src/main/scala/kafka/api/RequestOrResponse.scala > b62330be6241c8ff4acd21f0fa7e80b7636e0d42 > core/src/main/scala/kafka/server/KafkaApis.scala > 80a70f1e5e3a7670b2238fe63b8d9e0eac6b46ac > core/src/main/scala/kafka/server/ReplicaManager.scala > 54f6e1674255f62eba9d90aab0db371c82baf749 > core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala > f1f139e485d98e42be17cdcc327961420cd8c012 > > Diff: https://reviews.apache.org/r/15938/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >