> On Dec. 10, 2013, 4:14 p.m., Jun Rao wrote: > > It seems that in the consumer, we have a separate request timeout and > > socket timeout. The producer only has a request timeout now. Perhaps we > > should add the socket timeout in the producer too?
Currently request.timeout.ms of producer config is used as both socket timeout for the channel and produce ack timeout. Are you suggesting decoupling them by adding another socket timeout parameter? - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16092/#review30101 ----------------------------------------------------------- On Dec. 9, 2013, 5:14 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16092/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2013, 5:14 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1147 > https://issues.apache.org/jira/browse/KAFKA-1147 > > > Repository: kafka > > > Description > ------- > > KAFKA-1147.v2.1 > > > KAFKA-1147.v2 > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerConfig.scala > c8c4212f62dd52158e6504cba87b300e6830e5fe > core/src/main/scala/kafka/server/KafkaConfig.scala > a7e5b739454aec796070d95b003f20f79c84ef89 > > Diff: https://reviews.apache.org/r/16092/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
