> On Dec. 12, 2013, 12:17 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 773 > > <https://reviews.apache.org/r/15711/diff/6/?file=396094#file396094line773> > > > > Currently, all admin tools depend on state changes like preferred > > replica election/partition reassignment go through zookeeper. This helps > > the tools build a progress report. I think the ideal end state is still an > > admin RPC, but until we have that, it will be worth investigating if we can > > keep that property in this patch.
We now use zk to perform auto rebalance. If rebalance was triggered by the tool, we just fail auto rebalance and try the next time. If the tool was trying to rebalance when auto rebalance was in progress, we fail which is similar behavior to what it is today. > On Dec. 12, 2013, 12:17 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 234 > > <https://reviews.apache.org/r/15711/diff/6/?file=396095#file396095line234> > > > > This is a config that we may not need in the future once we are sure > > that the zookeeper callbacks work fine in the controller. In that case, > > could we just depend on imbalance.check.interval.seconds to turn this > > feature on/off? We have a delay config in scheduler that triggers the first rebalance. We need to add a config for that to make that a really large value which would be another config anyway. So I guess we would have to keep the enable config. - Sriram ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review30236 ----------------------------------------------------------- On Dec. 20, 2013, 7:23 p.m., Sriram Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15711/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2013, 7:23 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-930 > https://issues.apache.org/jira/browse/KAFKA-930 > > > Repository: kafka > > > Description > ------- > > some more changes > > > use zk for auto rebalance > > > Address code review feedbacks > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > > commit missing code > > > some more changes > > > fix merge conflicts > > > Add auto leader rebalance support > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > Conflicts: > core/src/main/scala/kafka/admin/AdminUtils.scala > core/src/main/scala/kafka/admin/TopicCommand.scala > > change comments > > > commit the remaining changes > > > Move AddPartitions into TopicCommand > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3 > core/src/main/scala/kafka/server/KafkaConfig.scala > b324344d0a383398db8bfe2cbeec2c1378fe13c9 > > Diff: https://reviews.apache.org/r/15711/diff/ > > > Testing > ------- > > > Thanks, > > Sriram Subramanian > >
