----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review31299 -----------------------------------------------------------
In general, does the alternate approach of sending all commands to every broker and let the broker ignore a become follower if it is for the same leader as the current one? The reason why this would work is because all controller-broker communication is synchronous, so even if the same broker became leader in quick succession (1->2->1), the follower would see the 1->2 transition before seeing the 2->1, so it wouldn't incorrectly ignore a become follower request from the same leader. - Neha Narkhede On Jan. 2, 2014, 6:44 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16360/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2014, 6:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1188 > https://issues.apache.org/jira/browse/KAFKA-1188 > > > Repository: kafka > > > Description > ------- > > KAFKA-1188.v3 > > > KAFKA-1118.v2 > > > KAFKA-1188.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 5c9307d71641ccc6c09a54b69d5aa2b4bc2a4cde > core/src/main/scala/kafka/server/ReplicaManager.scala > 242c18d47828b7c5e6b1fc219a0f1199fb1f9512 > > Diff: https://reviews.apache.org/r/16360/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
