----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17649/#review33851 -----------------------------------------------------------
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java <https://reviews.apache.org/r/17649/#comment63469> That's right. The existing mirror maker uses Utils.abs(java.util.Arrays.hashCode...) We should just stick with that. core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java <https://reviews.apache.org/r/17649/#comment63472> If the producer is configured to throw QFE or if it throws any other exception, then this would effectively stop this mirror thread. core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java <https://reviews.apache.org/r/17649/#comment63465> It's a bit odd to have this written in java and be under core/src/main/scala. Also, if this is not a temporary implementation then can you use an option parser as opposed to directly grabbing the CLI args? Also, I don't see any of the logging from before which we would want even if it is a temporary tool under test. core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java <https://reviews.apache.org/r/17649/#comment63474> If the mirror thread exits abnormally then it would be better to close the producers cleanly as well over here. (This is one reason the existing mirror maker uses a cleanShutdown method that we call from the shutdown hook as well as here.) - Joel Koshy On Feb. 4, 2014, 9:12 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17649/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 9:12 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1137 and KAFKA-1237 > https://issues.apache.org/jira/browse/KAFKA-1137 > https://issues.apache.org/jira/browse/KAFKA-1237 > > > Repository: kafka > > > Description > ------- > > Removed the tabs > > > Rebased to new producer API changes > > > removing whitespaces > > > removing whitespaces > > > Joel's review suggestions > > > Mirror maker using new producer. Does not work for auto created topics > (KAFKA-1238) > > > Diffs > ----- > > bin/kafka-run-class.sh 416ecadf27333d1524518e8229541d161449e282 > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java PRE-CREATION > project/Build.scala ddcfc4176e68933377590e095c07283083249f4a > > Diff: https://reviews.apache.org/r/17649/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
