[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893925#comment-13893925
]
Joel Koshy commented on KAFKA-1171:
-----------------------------------
1 - build.gradle: there should be a programmatic way to enumerate the versions
for dependsOn as opposed to explicitly enumerating. Ideally, the versions
should only be specified once in some global list.
2 - Would love it if we can avoid the additional copyDependantLibs step which
is extremely annoying. It seems possible by specifying a task dependency
and it is worth doing.
3 - gradlew tasks shows a number of tasks. I'm not sure if some are to be used
or not. E.g., ./gradlew builds, but then is it redundant to jar? Can
redundant or irrelevant tasks be hidden? Basically it would be nice to
have consistency between the readme and the tasks output. I'd rather have
one way to do something than several. I don't care too much but it is a
bit annoying if the menu shows a lot of options when only half of them are
to be used.
4 - kafka-run-class.sh: Why is it there are scala version-specific jars for
dependant libs and not for kafka-perf* and kafka*? E.g., if we were to do
jar_all and then kafka-run-class.sh there would be multiple jars on the
classpath which is a problem - I got an exception.
5 - Can we get the stand-alone tests available in a test jar or something like
that? This seems broken on the sbt side as well.
6 - Would be good to add a line to README.md on how to run a specific unit
test.
7 - license plugin: seems very useful. I just ran ./gradlew licenseFormatMain
and licenseFormatTest and it seems a number of files need license headers.
> Gradle build for Kafka
> ----------------------
>
> Key: KAFKA-1171
> URL: https://issues.apache.org/jira/browse/KAFKA-1171
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
> Affects Versions: 0.8.1, 0.9.0
> Reporter: David Arthur
> Assignee: David Arthur
> Priority: Blocker
> Attachments: 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> 0001-Adding-basic-Gradle-build.patch, 0001-Adding-basic-Gradle-build.patch,
> kafka-1171_v10.patch, kafka-1171_v11.patch, kafka-1171_v12.patch,
> kafka-1171_v13.patch, kafka-1171_v14.patch, kafka-1171_v6.patch,
> kafka-1171_v7.patch, kafka-1171_v8.patch, kafka-1171_v9.patch
>
>
> We have previously discussed moving away from SBT to an
> easier-to-comprehend-and-debug build system such as Ant or Gradle. I put up a
> patch for an Ant+Ivy build a while ago[1], and it sounded like people wanted
> to check out Gradle as well.
> 1. https://issues.apache.org/jira/browse/KAFKA-855
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
