-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17918/
-----------------------------------------------------------
(Updated Feb. 11, 2014, 1:51 a.m.)
Review request for kafka.
Bugs: KAFKA-1233
https://issues.apache.org/jira/browse/KAFKA-1233
Repository: kafka
Description
-------
Three test cases included in Part I:
Incorporated Jay's comments.
1. Send API, with null key/value/partitionId/topic tested, check returned
offset. Currently passed.
2. All messages drained before close, also check that messages with the same
key go to the same partition. Currently passed.
3. The default round robin partitioner, and the specified partition id is
respected. Currently broken with ack = -1. Filed KAFKA-1255.
4. Send with auto-topic-creation. Currently passed.
Diffs
-----
build.gradle 858d297b9e8bf8a2bca54c4817f9ca2affd0d3f2
core/src/test/resources/log4j.properties
d7d03ea1b13299d4ee41b9907720d014c81faf66
core/src/test/scala/integration/kafka/api/ProducerSendTest.scala PRE-CREATION
project/Build.scala ddcfc4176e68933377590e095c07283083249f4a
Diff: https://reviews.apache.org/r/17918/diff/
Testing
-------
Thanks,
Guozhang Wang
