----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16360/#review34406 -----------------------------------------------------------
Ship it! Only minor comments core/src/main/scala/kafka/cluster/Partition.scala <https://reviews.apache.org/r/16360/#comment64521> remove extra TopicAndPartition import core/src/main/scala/kafka/server/ReplicaManager.scala <https://reviews.apache.org/r/16360/#comment64495> could you please wrap the long line here? - Neha Narkhede On Feb. 12, 2014, 1:58 a.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16360/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 1:58 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1188 > https://issues.apache.org/jira/browse/KAFKA-1188 > > > Repository: kafka > > > Description > ------- > > Rebased on delete-topics > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 1087a2e91c86e36a2494a95913a3ec2daf238287 > core/src/main/scala/kafka/controller/ReplicaStateMachine.scala > 5e016d5d2bbef7fc33fb80c9a4a90ec5d39c16d0 > core/src/main/scala/kafka/server/ReplicaManager.scala > 21bba48affb38ff6504e02535d3cc56258f45b60 > > Diff: https://reviews.apache.org/r/16360/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
