----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18441/#review35375 -----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/18441/#comment65865> The io thread in the producer is also called kafka-network-thread. Could we distinguish them? - Jun Rao On Feb. 24, 2014, 10:47 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18441/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 10:47 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1279 > https://issues.apache.org/jira/browse/KAFKA-1279 > > > Repository: kafka > > > Description > ------- > > KAFKA-1279 Socket server should close all connections when it is shutdown. > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 216245deb119c8f5e8710b25d5093c456398c568 > core/src/test/scala/unit/kafka/network/SocketServerTest.scala > 4ff6f55914909ce4b3b6e66741e918093a1f524c > > Diff: https://reviews.apache.org/r/18441/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
