----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/ -----------------------------------------------------------
(Updated March 3, 2014, 11:22 p.m.) Review request for kafka. Bugs: KAFKA-1281 https://issues.apache.org/jira/browse/KAFKA-1281 Repository: kafka Description (updated) ------- First pass at refactoring tools to use the new producer. As per agreement on KAFKA-1281, only ConsoleProducer and ProducerPerformance have the option of using the 2 producers. Rest are converted over to use the new producer. KafkaLog4jAppender needs an overhaul, I think. For this patch, I've just converted it to use the new producer and deleted configs that only make sense for the old producer. Diffs ----- core/src/main/scala/kafka/producer/ConsoleProducer.scala 28de57304db6a7c79c4c75de155f6389144eb5a5 core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala 42239b27ab26725141f4bf525d2d69538979dd44 core/src/main/scala/kafka/tools/ReplayLogProducer.scala 814d61ae477cef5e56723e1f1a86c3b2e9b7c1ea core/src/main/scala/kafka/utils/CommandLineUtils.scala 726c30257dcb55b8989163dab3bfc6888dd5d931 core/src/test/scala/other/kafka/TestEndToEndLatency.scala f5d39dd71ad25b0d9955d4b9bcdb56ba705abff0 core/src/test/scala/other/kafka/TestLogCleaning.scala 22b16e54980e30f60dbf2fbe46c16398d654ba21 Diff: https://reviews.apache.org/r/18712/diff/ Testing ------- Thanks, Neha Narkhede