LGTM. +1 (binding) -Harsha
On Wed, Sep 04, 2019 at 1:46 AM, Satish Duggana <satish.dugg...@gmail.com> wrote: > +1 (non-binding) Thanks for the nice KIP. > > You may want to update the KIP saying that optional tagged fields do not > support complex types(or structs). > > On Wed, Sep 4, 2019 at 3:43 AM Jose Armando Garcia Sancio > <jsan...@confluent.io> wrote: > > +1 (non-binding) > > Looking forward to this improvement. > > On Tue, Sep 3, 2019 at 12:49 PM David Jacot <dja...@confluent.io> wrote: > > +1 (non-binding) > > Thank for the KIP. Great addition to the Kafka protocol! > > Best, > David > > Le mar. 3 sept. 2019 à 19:17, Colin McCabe <cmcc...@apache.org> a écrit : > > Hi all, > > I'd like to start the vote for KIP-482: The Kafka Protocol should Support > Optional Tagged Fields. > > KIP: > > https://cwiki.apache.org/confluence/display/KAFKA/ > KIP-482%3A+The+Kafka+Protocol+should+Support+Optional+Tagged+Fields > > Discussion thread here: > > https://lists.apache.org/thread.html/ > cdc801ae886491b73ef7efecac7ef81b24382f8b6b025899ee343f7a@%3Cdev.kafka. > apache.org%3E > > best, > Colin > > -- > -Jose > >
