The vote has passed with 4 binding votes (Colin, Manikumar, Harsha, Rajini) and 2 non-binding votes (Satish, Kamal). I will update the KIP page and submit a PR.
Many thanks for the discussion and votes. Regards, Rajini On Tue, Sep 24, 2019 at 9:22 AM Rajini Sivaram <rajinisiva...@gmail.com> wrote: > > Hi Satish, I have updated the KIP to use TopicMetadataAndConfig for the > inner class instead of CreateResult. > > I also fixed the version in the protocol to use 5 instead of 6 since the > update to version 5 in KIP-482 will be going out in the same release as > this KIP. > > Since both are minor changes that don't affect the externals, I won't > restart the vote. > > Regards, > > Rajini > > On Mon, Sep 23, 2019 at 1:01 PM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > >> +1 (non-binding), Thanks for the KIP! >> >> On Mon, Sep 23, 2019 at 10:45 AM Satish Duggana <satish.dugg...@gmail.com >> > >> wrote: >> >> > Thanks for the KIP, +1 (non binding) >> > >> > This looks to be a useful API for admin tools. When we worked on an >> > admin tool for Kafka, we had to explicitly call the config API for >> > showing the configs for the newly created topic. >> > I have a minor-nit comment on `CreateResult` which seems to be a >> > slightly confusing name as it is not really about the CreateResult of >> > a topic but it is about topic metadata and config(maybe >> > TopicMetadataWithConfig). This does not need to be addressed in the >> > KIP now as it is not exposed to clients. But you may want to address >> > this in the PR later. >> > >> > >> > On Sun, Sep 22, 2019 at 9:02 PM Harsha Chintalapani <ka...@harsha.io> >> > wrote: >> > > >> > > +1 (binding). >> > > -Harsha >> > > >> > > >> > > On Sat, Sep 21, 2019 at 12:13 AM, Manikumar < >> manikumar.re...@gmail.com> >> > > wrote: >> > > >> > > > +1 (binding), Thanks for the KIP. >> > > > >> > > > Thanks, >> > > > >> > > > On Sat, Sep 21, 2019 at 2:49 AM Colin McCabe <cmcc...@apache.org> >> > wrote: >> > > > >> > > > +1 (binding). Thanks, Rajini. >> > > > >> > > > best, >> > > > Colin >> > > > >> > > > On Fri, Sep 20, 2019, at 00:43, Rajini Sivaram wrote: >> > > > >> > > > Hi all, >> > > > >> > > > I would like to start vote on KIP-525 to return configs in >> CreateTopics >> > > > response. This is a minor KIP that returns additional data in the >> > > > >> > > > response >> > > > >> > > > without breaking compatibility. >> > > > >> > > > - >> > > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/ >> > > > KIP-525+-+Return+topic+metadata+and+configs+in+CreateTopics+response >> > > > >> > > > Thank you, >> > > > >> > > > Rajini >> > > > >> > > > >> > >> >
