Thanks, I'm +1 (binding). On Tue, Oct 8, 2019 at 2:33 AM Nikolay Izhikov <nizhi...@apache.org> wrote:
> Hello, Guozhang. > > Following added to the KIP: > > > If not null parameters passed then an java.lang.IllegalArgumentException > will be thrown. > > В Пн, 07/10/2019 в 15:51 -0700, Guozhang Wang пишет: > > Hello Nikolay, > > > > Could you clarify in the wiki doc what would happen if the passed in > > `byte[] bytes` or `Void data` parameters are not null? From the example > PR > > we would throw exception here. I think it worth documenting it as part of > > the contract in the wiki page. > > > > Otherwise, I'm +1. > > > > > > Guozhang > > > > On Mon, Oct 7, 2019 at 3:19 PM Bill Bejeck <bbej...@gmail.com> wrote: > > > > > Thanks for the KIP. > > > > > > +1(binding) > > > > > > -Bill > > > > > > On Mon, Oct 7, 2019 at 5:57 PM Matthias J. Sax <matth...@confluent.io> > > > wrote: > > > > > > > +1 (binding) > > > > > > > > > > > > -Matthias > > > > > > > > On 10/6/19 8:02 PM, Nikolay Izhikov wrote: > > > > > Hello, > > > > > > > > > > Any additional feedback on this? > > > > > Do we need this in Kafka? > > > > > > > > > > В Ср, 02/10/2019 в 08:30 +0200, Bruno Cadonna пишет: > > > > > > Hi Nikolay, > > > > > > > > > > > > Thank you for the KIP! > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Best, > > > > > > Bruno > > > > > > > > > > > > On Tue, Oct 1, 2019 at 5:57 PM Nikolay Izhikov < > nizhi...@apache.org> > > > > > > > > wrote: > > > > > > > > > > > > > > Hello. > > > > > > > > > > > > > > I would like to start vote for KIP-527: Add VoidSerde to Serdes > > > > > > > > > > > > > > KIP - > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+VoidSerde+to+Serdes > > > > > > > Discussion thread - > > > > > > > https://lists.apache.org/thread.html/e6f95799898cc5d6e7d44dfd3fc2206117feb384a0a229a1c781ecd4@%3Cdev.kafka.apache.org%3E > > > > > > > > > > > > > > > > > > > > -- -- Guozhang
