Hello. This improvement merged. Thanks Colin for the review.
В Пт, 18/10/2019 в 15:02 -0700, Colin McCabe пишет: > Hi Nikolay, > > Sorry that I haven't had more bandwidth to review this recently. I will take > a look today. > > In the future, can you please rebase your changes on top of trunk, rather > than merging trunk into your branch? It is difficult to follow which changes > are yours and which come from the merge, when you do it the other way. > > best, > Colin > > > On Thu, Oct 17, 2019, at 02:59, Nikolay Izhikov wrote: > > Hello. > > > > Is there something wrong with the PR? > > Do we need this ticket to be done? [2] > > If no, let's close both PR [1] and ticket. > > > > The design or implementation details were changed? > > If yes, can you, please, send a link where I can find details. > > > > [1] https://github.com/apache/kafka/pull/7342 > > [2] https://issues.apache.org/jira/browse/KAFKA-8885 > > > > пн, 7 окт. 2019 г. в 10:08, Nikolay Izhikov <nizhi...@apache.org>: > > > > > Hello. > > > > > > Please, review my changes [1] > > > I fixed all conflicts after KAFKA-8885 [2] merge [3]. > > > > > > [1] https://github.com/apache/kafka/pull/7342 > > > [2] https://issues.apache.org/jira/browse/KAFKA-8885 > > > [3] > > > https://github.com/apache/kafka/commit/0de61a4683b92bdee803c51211c3277578ab3edf > > > > > > В Пт, 20/09/2019 в 09:18 -0700, Colin McCabe пишет: > > > > Hi Nikolay, > > > > > > > > Thanks for working on this. I think everyone agrees that we should have > > > > > > byte buffer support in the generator. We just haven't had a lot of time > > > for reviewing it lately. I don't really mind which PR we use :) I will > > > take a look at your PR today and see if we can get it into shape for what > > > we need. > > > > > > > > best, > > > > Colin > > > > > > > > On Fri, Sep 20, 2019, at 09:18, Nikolay Izhikov wrote: > > > > > Hello, all. > > > > > > > > > > Any feedback on this? > > > > > Do we need support of ByteBuffer in RPC generated code? > > > > > > > > > > Which PR should be reviwed and merged? > > > > > > > > > > В Чт, 19/09/2019 в 10:11 +0300, Nikolay Izhikov пишет: > > > > > > Hello, guys. > > > > > > > > > > > > Looks like we have duplicate tickets and PR's here. > > > > > > > > > > > > One from me: > > > > > > > > > > > > KAFKA-8584: Support of ByteBuffer for bytes field implemented. > > > > > > ticket - https://issues.apache.org/jira/browse/KAFKA-8584 > > > > > > pr - https://github.com/apache/kafka/pull/7342 > > > > > > > > > > > > and one from Colin McCabe: > > > > > > > > > > > > KAFKA-8628: Auto-generated Kafka RPC code should be able to use > > > > > > zero-copy ByteBuffers > > > > > > ticket - https://issues.apache.org/jira/browse/KAFKA-8628 > > > > > > pr - https://github.com/apache/kafka/pull/7032 > > > > > > > > > > > > I want to continue work on my PR and got it merged. > > > > > > But, it up to community to decide which changes are best for the > > > > > > product. > > > > > > > > > > > > Please, let me know, what do you think. > > > > > > > > > > > > > > > > > > В Вт, 17/09/2019 в 01:52 +0300, Nikolay Izhikov пишет: > > > > > > > Hello, Kafka team. > > > > > > > > > > > > > > I implemented KAFKA-8584 [1]. > > > > > > > PR - [2] > > > > > > > Please, do the review. > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/KAFKA-8584 > > > > > > > [2] https://github.com/apache/kafka/pull/7342 > > > > > > > > > > Attachments: > > > > > * signature.asc
signature.asc
Description: This is a digitally signed message part
