Ivan Yurchenko created KAFKA-9143:
-------------------------------------
Summary: DistributedHerder misleadingly log error on connector
task reconfiguration
Key: KAFKA-9143
URL: https://issues.apache.org/jira/browse/KAFKA-9143
Project: Kafka
Issue Type: Bug
Components: KafkaConnect
Reporter: Ivan Yurchenko
Assignee: Ivan Yurchenko
In {{DistributedHerder}} in {{reconfigureConnectorTasksWithRetry}} method
there's a
[callback|https://github.com/apache/kafka/blob/c552c06aed50b4d4d9a85f73ccc89bc06fa7e094/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java#L1247]:
{code:java}
@Override
public void onCompletion(Throwable error, Void result) {
log.error("Unexpected error during connector task reconfiguration: ",
error);
log.error("Task reconfiguration for {} failed unexpectedly, this connector
will not be properly reconfigured unless manually triggered.", connName);
}
{code}
It an error message even when the operation succeeded (i.e., {{error}} is
{{null}}).
It should include {{if (error != null)}} condition, like in the same class [in
another
method|https://github.com/apache/kafka/blob/c552c06aed50b4d4d9a85f73ccc89bc06fa7e094/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java#L792].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
