Hi Viktor, -1, @Vahid already provided the info. -2, Moved the KIP to the parent path instead of KIP-36, thanks for finding out.
--sbellapu On 2019/11/22 10:57:35, Viktor Somogyi-Vass <viktorsomo...@gmail.com> wrote: > Hi Satish, > > Couple of questions/suggestions: > 1. You say that when you execute the planned reassignment then it would > throw an error if the generated reassignment doesn't comply with the > rack-aware requirement. Opposed to this: why don't you have the --generate > option to generate a rack-aware reassignment plan? This way users won't > have to do the extra round. > 2. Please move your KIP under > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals > , > people will have a hard time finding it if it's under KIP-36. > (@Stan fyi: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-548+Add+Option+to+enforce+rack-aware+custom+partition+reassignment+execution > ) > > Thanks, > Viktor > > On Fri, Nov 22, 2019 at 11:37 AM Stanislav Kozlovski <stanis...@confluent.io> > wrote: > > > Hello Satish, > > > > Could you provide a link to the KIP? I am unable to find it in the KIP > > parent page > > > > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals > > > > Thanks, > > Stanislav > > > > On Fri, Nov 22, 2019 at 8:21 AM Satish Bellapu <satishbabu...@gmail.com> > > wrote: > > > > > Hi All, > > > > > > This [KIP-548] is basically extending the capabilities of > > > "kafka-reassign-partitions" tool by adding rack-aware verification option > > > when used along with custom or manually generated reassignment planner > > with > > > --execute scenario. > > > > > > @sbellapu. > > > > > > > > > -- > > Best, > > Stanislav > > >
