-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20529/
-----------------------------------------------------------
(Updated April 21, 2014, 11:33 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Follow-up KAFKA-1359: incorporate Neha's comments
Bugs: KAFKA-1359
https://issues.apache.org/jira/browse/KAFKA-1359
Repository: kafka
Description (updated)
-------
Incorporate Neha's comments
minor fixes
Followup on K1359: change nanoTime to currentTimeMillis in metrics, fix a small
issue for metadata age calculation
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/internals/Metadata.java
33d62a4b83fbab5b22b91b22f6b744af1c98d262
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
ffd13ff00ba0d0d969e2ed130e49053f02481b50
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java
94157f7a3bc058d98f58d1d3c6bb5d5b1196f69d
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
9f2b2e95fed957783834923c4cb65cff50b81e58
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java
b2426ac9274688b3a658fd03ff5e57cd5dea5c93
clients/src/main/java/org/apache/kafka/common/metrics/Measurable.java
0f405c3f81314c14688045737857865c455b6073
clients/src/main/java/org/apache/kafka/common/metrics/MetricConfig.java
4d14fbcc68a806ef86a692b3d032fd3d8f06b6d6
clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java
d68349bf94b2ce7b117f5e4b168ef982ac2f392d
clients/src/main/java/org/apache/kafka/common/metrics/Stat.java
e02389c969f52e3ee9627fd99999bf78f2470878
clients/src/main/java/org/apache/kafka/common/metrics/stats/Avg.java
51725b278495f1cb4b492e98847056e61614f4e7
clients/src/main/java/org/apache/kafka/common/metrics/stats/Count.java
3cdd1d054e0b989bb1c2ab3c63944c3861896099
clients/src/main/java/org/apache/kafka/common/metrics/stats/Max.java
bba59721faa146758dd0b9c30e2d7a8354ca6fc8
clients/src/main/java/org/apache/kafka/common/metrics/stats/Min.java
d370049a7f1c0905a64c00131af05e44566026ec
clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java
b47ed88d6749240ec221cd20453c0b0d8a0ff191
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java
7f5cc53c2e62b9de074c3ad58c270fcf19aae8b3
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java
776f3a1656d7efc597a08b5e7caef29dc3c478b2
clients/src/main/java/org/apache/kafka/common/metrics/stats/Total.java
a9940ed7ea1db2c1340ec110b62a6a9efeb4c52d
clients/src/main/java/org/apache/kafka/common/network/Selector.java
6027cb2de3a5c8b6acba66396133d73bdff075b6
clients/src/main/java/org/apache/kafka/common/utils/SystemTime.java
6582c73dab6344e0796109f804cb726480c6b235
clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java
9ff73f4afe72fb016a0e9a88ca821d3d342b9556
clients/src/test/java/org/apache/kafka/test/Microbenchmarks.java
6aab8542dbf924c17c8bd31fd4883d3196fbad72
Diff: https://reviews.apache.org/r/20529/diff/
Testing
-------
Thanks,
Guozhang Wang
