----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20616/#review41182 -----------------------------------------------------------
core/src/main/scala/kafka/cluster/Partition.scala <https://reviews.apache.org/r/20616/#comment74599> This should be a readLock since this call doesn't change the leader or the isr. core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/20616/#comment74630> Message rate is supposed to be based on deep messages, not shallow messages. Perhaps we can collect the stat for the incoming byte/message rate after the log append. - Jun Rao On April 23, 2014, 5:29 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20616/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 5:29 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1409 > https://issues.apache.org/jira/browse/KAFKA-1409 > > > Repository: kafka > > > Description > ------- > > minor changes > > > KAFKA-1409.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > c08eab0bc35aa2b0caa0dfc1987b4face4315d3b > core/src/main/scala/kafka/javaapi/message/ByteBufferMessageSet.scala > fecee8d5f7b32f483bb1bfc6a5080d589906f9c4 > core/src/main/scala/kafka/log/FileMessageSet.scala > b2652ddbe2f857028d5980e29a008b2c614694a3 > core/src/main/scala/kafka/log/Log.scala > 46df8d99d977a3b010a9b9f4698187fa9bfb2498 > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 73401c5ff34d08abce22267aa9c4d86632c6fb74 > core/src/main/scala/kafka/message/MessageSet.scala > a1b5c63b4d9deaa2556427d995c41841838cf581 > core/src/main/scala/kafka/server/KafkaApis.scala > bb0359d933356b8fcc2c8df22ce6ea9cb838d6a2 > > Diff: https://reviews.apache.org/r/20616/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
