[GitHub] [kafka] tombentley commented on issue #8222: KAFKA-9650: include human readable units in ms and bytes configs

[GitBox]

tombentley commented on issue #8222:
URL: https://github.com/apache/kafka/pull/8222#issuecomment-616538532


   @mimaison I rewrote that code, which I think makes it clear enough and 
avoids the repeated constants.
   
   Rendered it looks like this:
   
   ![Screenshot from 2020-04-20 
13-57-54](https://user-images.githubusercontent.com/879487/79754275-2f53f180-830f-11ea-87f8-8cb645704733.png)
   
   I wasn't too sure about the `=` in parens, but I thought it made it clearer 
that it wasn't part of the default value. I guess an alternative would be to 
use some other font, or italics to make that clear. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org