Based on the PR feedback, I have updated the KIP <https://cwiki.apache.org/confluence/display/KAFKA/KIP-569%3A+DescribeConfigsResponse+-+Update+the+schema+to+include+additional+metadata+information+of+the+field#KIP-569:DescribeConfigsResponse-Updatetheschematoincludeadditionalmetadatainformationofthefield-AbstractConfigClass> to include the update needed to AbstractConfig class. Please let me know if there are any questions/concerns.
Shailesh On Fri, Mar 20, 2020 at 8:49 AM Shailesh Panwar <span...@confluent.io> wrote: > I have 3 +1s and 1 +1(non-binding) vote for this Kip. Thank you all for > the feedback. I'll start working on the PR. > > Thanks > Shailesh > > > On Fri, Mar 20, 2020 at 8:35 AM Brian Byrne <bby...@confluent.io> wrote: > >> +1 (non-binding) - thanks! >> >> My only suggestion would be to make the enum-to-int conversion explicit >> for >> the new ConfigType, with a surrounding comment, to ensure that no >> accidental reordering and for easier readability should the response >> message message be read. >> >> Brian >> >> On Fri, Mar 20, 2020 at 8:13 AM David Arthur <mum...@gmail.com> wrote: >> >> > +1 binding. Thanks for the KIP 👍 >> > >> > -David >> > >> > On Tue, Mar 17, 2020 at 4:44 AM Rajini Sivaram <rajinisiva...@gmail.com >> > >> > wrote: >> > >> > > Hi Shailesh, >> > > >> > > +1 (binding) >> > > >> > > Thanks for the KIP! >> > > >> > > Regards, >> > > >> > > Rajini >> > > >> > > >> > > On Tue, Mar 10, 2020 at 2:37 AM Gwen Shapira <g...@confluent.io> >> wrote: >> > > >> > > > +1 >> > > > Looks great. Thanks for the proposal, Shailesh. >> > > > >> > > > Gwen Shapira >> > > > Engineering Manager | Confluent >> > > > 650.450.2760 | @gwenshap >> > > > Follow us: Twitter | blog >> > > > >> > > > On Mon, Mar 09, 2020 at 6:00 AM, Shailesh Panwar < >> > span...@confluent.io >> > > > >> > > > wrote: >> > > > >> > > > > >> > > > > >> > > > > >> > > > > Hi All, >> > > > > I would like to start a vote on KIP-569: Update >> > > > > DescribeConfigsResponse to include additional metadata information >> > > > > >> > > > > >> > > > > >> > > > > The KIP is here: >> > > > > https:/ / cwiki. apache. org/ confluence/ display/ KAFKA/ >> > > > >> > > >> > >> KIP-569%3A+DescribeConfigsResponse+-+Update+the+schema+to+include+additional+metadata+information+of+the+field >> > > > > ( >> > > > > >> > > > >> > > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-569%3A+DescribeConfigsResponse+-+Update+the+schema+to+include+additional+metadata+information+of+the+field >> > > > > ) >> > > > > >> > > > > >> > > > > >> > > > > Thanks, >> > > > > Shailesh >> > > > > >> > > > > >> > > > > >> > > >> > >> > >> > -- >> > David Arthur >> > >> >
